UI/TTL helperEnabled/DisabledText fix #12212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashishaw
reviewed
Aug 2, 2021
Monkeychip
reviewed
Aug 2, 2021
| @@ -29,14 +29,14 @@ export default Model.extend({ | |||
| editType: 'ttl', | |||
| defaultValue: '1h', | |||
| label: 'Generated credentials’s Time-to-Live (TTL)', | |||
| subText: 'Vault will use the engine default of 1 hour', | |||
| helperTextDisabled: 'Vault will use a TTL of 1 hour.', | |||
There was a problem hiding this comment.
Did Ivana have any thoughts on helperTextEnabled for these?
There was a problem hiding this comment.
No, but it'd be good to clarify a final time when she is back tomorrow.
There was a problem hiding this comment.
@Monkeychip - Ivana wants to stick with the default text!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI defaults to generate credentials' TTL and Max-TTL for a role respectively to expire after 1 hr and 24hrs respectively, so this update is to clarify this behavior to customers using the UI by explicitly stating these expiry times.
Old Role Text:
New Role Text:
Old Rotation TTL Text:
toggled off
toggled on
Corrected Text:
toggled off
toggled on
