Aerospike backend update #12165
Aerospike backend update #12165
Conversation
|
@ncabatoff could you please assist with the changelog entry failure in tests. |
Actually, in this case the check is correctly reporting a problem. You're making changes to production code, which should be reflected in the changelog. Please create a changelog entry in your PR, as per https://github.com/hashicorp/vault/blob/main/CONTRIBUTING.md#changelog-entries . |
|
@reugn can you run |
go.mod
Outdated
| @@ -53,7 +53,7 @@ require ( | |||
| github.com/go-sql-driver/mysql v1.5.0 | |||
| github.com/go-test/deep v1.0.7 | |||
| github.com/gocql/gocql v0.0.0-20210401103645-80ab1e13e309 | |||
| github.com/golang/protobuf v1.4.2 | |||
There was a problem hiding this comment.
@briankassouf or @ncabatoff do you see any potential issues with the protobuf bump here and below?
…e_backend_update # Conflicts: # go.mod # go.sum
|
@reugn would it be possible for you to resolve the merge conflicts on the go.mod and go.sum files? |
…e_backend_update # Conflicts: # go.mod # go.sum
|
@calvn resolved. |
|
Hey @reugn we were trying to get this in for 1.9 but due to logistics and code freeze, this didn't make it. We wanted to get this updated all the way to v5.6.0 back then, but it looks like you've gone ahead and done that since, so #13008 can be closed. I am trying to see if we can get this in for 1.9.1. |
|
Sure @calvn. Let me know if you need anything else before you merge this. |
|
@reugn we should be good to have this in for 1.9.1, but just to double-check on this since there's been a lot of changes in go.mod/go.sum recently, can you merge main in and run |
* upgrade aerospike-client-go to v5.2.0 * use strings.Contains to check an error * add changelog file * go mod tidy * go mod tidy * update the changelog * revert .gitignore update * go mod tidy
* upgrade aerospike-client-go to v5.2.0 * use strings.Contains to check an error * add changelog file * go mod tidy * go mod tidy * update the changelog * revert .gitignore update * go mod tidy Co-authored-by: Eugene R <[email protected]>
No description provided.