Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VAULT-2285 adding capability to accept comma separated entries for au… #12126

Merged
merged 17 commits into from
Aug 9, 2021
Merged

VAULT-2285 adding capability to accept comma separated entries for au… #12126

merged 17 commits into from
Aug 9, 2021

Conversation

hghaf099
Copy link
Contributor

…th enable/tune

@vercel vercel bot temporarily deployed to Preview – vault-storybook July 20, 2021 03:12 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook July 20, 2021 03:18 Inactive
@vercel vercel bot temporarily deployed to Preview – vault July 20, 2021 03:18 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook July 20, 2021 05:28 Inactive
@hghaf099 hghaf099 force-pushed the hghaf099-VAULT-2285-fix-headers-accept-comma-sep-ent branch from 3e6c136 to e8515b3 Compare July 20, 2021 14:13
@vercel vercel bot temporarily deployed to Preview – vault-storybook July 20, 2021 14:13 Inactive
@vercel vercel bot temporarily deployed to Preview – vault July 20, 2021 14:13 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook July 20, 2021 14:22 Inactive
@hghaf099 hghaf099 requested a review from ncabatoff July 20, 2021 14:22
@hghaf099
Copy link
Contributor Author

Seems like secrets tune/enable are also missing the same parameters.

@vercel vercel bot temporarily deployed to Preview – vault-storybook July 20, 2021 14:52 Inactive
@hghaf099 hghaf099 marked this pull request as ready for review July 20, 2021 14:52
ncabatoff
ncabatoff reviewed Jul 20, 2021
View reviewed changes
website/content/docs/commands/secrets/tune.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/secrets/tune.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/secrets/enable.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/secrets/enable.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/auth/tune.mdx Outdated Show resolved Hide resolved
vault/logical_system.go Outdated Show resolved Hide resolved
vault/logical_system.go Outdated Show resolved Hide resolved
vault/logical_system.go Outdated Show resolved Hide resolved
changelog/12126.txt Outdated Show resolved Hide resolved
changelog/12126.txt Outdated Show resolved Hide resolved
@hghaf099
Adding further parameter checks for auth/secret tests
ef999e7 
Fixing changelog
using builtin type for a switch statement
Fixing a possible panic scenario
@vercel vercel bot temporarily deployed to Preview – vault-storybook July 20, 2021 17:52 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook July 20, 2021 17:54 Inactive
@hghaf099 hghaf099 requested a review from ncabatoff July 21, 2021 14:36
ncabatoff
ncabatoff reviewed Jul 22, 2021
View reviewed changes
command/secrets_tune_test.go Outdated Show resolved Hide resolved
vault/logical_system.go Outdated Show resolved Hide resolved
vault/logical_system.go Outdated Show resolved Hide resolved
vault/logical_system.go Outdated Show resolved Hide resolved
vault/logical_system.go Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault-storybook July 23, 2021 23:21 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook July 23, 2021 23:23 Inactive
@hghaf099 hghaf099 requested a review from ncabatoff July 26, 2021 16:26
ncabatoff
ncabatoff reviewed Jul 27, 2021
View reviewed changes
vault/logical_system.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault-storybook July 27, 2021 15:32 Inactive
@vercel vercel bot temporarily deployed to Preview – vault July 27, 2021 15:32 Inactive
@hghaf099 hghaf099 requested a review from ncabatoff July 27, 2021 21:04
@vercel vercel bot temporarily deployed to Preview – vault-storybook July 30, 2021 19:20 Inactive
ncabatoff
ncabatoff approved these changes Aug 8, 2021
View reviewed changes
Copy link
Collaborator

@ncabatoff ncabatoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small suggestions but overall looks good!

@vercel vercel bot temporarily deployed to Preview – vault-storybook August 9, 2021 17:09 Inactive
@hghaf099 hghaf099 merged commit dd294fc into main Aug 9, 2021
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 27, 2021 18:41 Inactive
@briankassouf briankassouf deleted the hghaf099-VAULT-2285-fix-headers-accept-comma-sep-ent branch September 27, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncabatoff ncabatoff ncabatoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hghaf099 @ncabatoff