Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node to latest stable version #12049

Merged
merged 3 commits into from
Jul 22, 2021
Merged

Update node to latest stable version #12049

merged 3 commits into from
Jul 22, 2021

Conversation

arnav28
Copy link
Contributor

@arnav28 arnav28 commented Jul 12, 2021 •
edited
Loading

  • v10 has reached EOL so upgrading node to v14 which is the latest
    stable build

UI specific changes:

  1. Update engine in the package.json to enforce the node version
  2. Update .nvmrc file for nvm use

Infra/build changes:

  1. Install packagespec: https://github.com/hashicorp/packagespec#installation
  2. Update the node version for docker (scripts > docker > dockerfile)
  3. Update the node image in .circleci > config > executors > @executors.yml
  4. Update node version in packages-oss.yml
  5. Run make packages
  6. This will update the circle ci and build configuration files
  7. Commit all the changes (including the auto-updated files)

@vercel vercel bot temporarily deployed to Preview – vault July 12, 2021 20:59 Inactive
@arnav28 arnav28 added the ui label Jul 12, 2021
@vercel vercel bot temporarily deployed to Preview – vault-storybook July 12, 2021 21:10 Inactive
Monkeychip
Monkeychip approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this and for adding the steps! Not sure if you think we should have a release engineer also preview but might be worth having them look.

sarahethompson
sarahethompson approved these changes Jul 13, 2021
View reviewed changes
Copy link
Collaborator

@sarahethompson sarahethompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the packagespec side

arnav28 added 3 commits July 22, 2021 13:35
@arnav28
Update node to latest stable version
417b479 
- v10 has reached EOL so upgrading node to v14 which is the latest
stable build
@arnav28
Added changelog
2fce112
@arnav28
Resolve merge conflicts
a004de7
@vercel vercel bot temporarily deployed to Preview – vault July 22, 2021 20:38 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook July 22, 2021 20:38 Inactive
@arnav28 arnav28 merged commit e8bcb69 into main Jul 22, 2021
arnav28 added a commit that referenced this pull request Jul 22, 2021
@arnav28
Update node to latest stable version (#12049)
3addb4c 
* Update node to latest stable version

- v10 has reached EOL so upgrading node to v14 which is the latest
stable build

* Added changelog

* Resolve merge conflicts
arnav28 added a commit that referenced this pull request Jul 22, 2021
@arnav28
Update node to latest stable version (#12049)
3210f5a 
* Update node to latest stable version

- v10 has reached EOL so upgrading node to v14 which is the latest
stable build

* Added changelog

* Resolve merge conflicts
This was referenced Jul 22, 2021
Merged
Merged
arnav28 added a commit that referenced this pull request Jul 22, 2021
@arnav28
Update node to latest stable version (#12049) (#12154)
ca2ad70 
* Update node to latest stable version

- v10 has reached EOL so upgrading node to v14 which is the latest
stable build

* Added changelog

* Resolve merge conflicts
arnav28 added a commit that referenced this pull request Jul 22, 2021
@arnav28
Update node to latest stable version (#12049) (#12155)
24c9176 
* Update node to latest stable version

- v10 has reached EOL so upgrading node to v14 which is the latest
stable build

* Added changelog

* Resolve merge conflicts
@arnav28 arnav28 deleted the ui/upgrade_node branch July 22, 2021 23:54
@hashishaw hashishaw mentioned this pull request Apr 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahethompson sarahethompson sarahethompson approved these changes

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnav28 @Monkeychip @sarahethompson