Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secrets/openldap: add schema config to rotate-root #12019

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Conversation

jasonodonnell
Copy link
Contributor

Updating the OpenLDAP secret engine to include this bug fix: hashicorp/vault-plugin-secrets-openldap#24

@jasonodonnell jasonodonnell added this to the 1.8 milestone Jul 8, 2021
@jasonodonnell jasonodonnell changed the title update go mod & go mod tidy secrets/openldap: add schema config to rotate-root Jul 8, 2021
@vercel vercel bot temporarily deployed to Preview – vault-storybook July 8, 2021 16:46 Inactive
@vercel vercel bot temporarily deployed to Preview – vault July 8, 2021 16:46 Inactive
@jasonodonnell jasonodonnell merged commit 9bf3b4b into main Jul 8, 2021
@jasonodonnell jasonodonnell deleted the openldap-v0.5.1 branch July 8, 2021 17:53
@ccapurso
Copy link
Contributor

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

@ccapurso
Copy link
Contributor

Sorry, the above comment was generated by running changelog-pr-body-check as I was looking into issues where certain changelog entries were missing from CHANGELOG.md. The entry listed in changelog/12019.txt does look like it has an issue. The type should be bug instead of bug-fix.

@jasonodonnell
Copy link
Contributor Author

jasonodonnell commented Jul 16, 2021

Fixed in #12112. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants