Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Show day of month instead of day of year in the expiration warning dialog #11984

Merged
merged 3 commits into from
Sep 2, 2021
Merged

UI: Show day of month instead of day of year in the expiration warning dialog #11984

merged 3 commits into from
Sep 2, 2021

Conversation

balent
Copy link
Contributor

@balent balent commented Jul 2, 2021 •
edited
Loading

Fixes #11619

@hashicorp-cla
Copy link

hashicorp-cla commented Jul 2, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vercel vercel bot temporarily deployed to Preview – vault July 2, 2021 22:15 Inactive
@vercel vercel bot temporarily deployed to Preview – vault July 2, 2021 22:22 Inactive
arnav28
arnav28 approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@arnav28 arnav28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it 👍

@arnav28 arnav28 added the ui label Jul 22, 2021
@zerkms
Copy link
Contributor

zerkms commented Aug 16, 2021

Why wouldn't this little change be merged?

@balent
Copy link
Contributor Author

balent commented Aug 17, 2021

I'm not authorized to merge. Can somebody with the right permissions merge? Thanks!

hashishaw
hashishaw approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this change!

@hashishaw hashishaw added bug Used to indicate a potential bug backport labels Sep 2, 2021
@hashishaw hashishaw added this to the 1.7.5 milestone Sep 2, 2021
@heatherezell
Copy link
Contributor

Hi @balent! Apologies for the delay on getting this merged. Would you be willing to refresh these code changes with the current main, so we can get it unblocked in our automated tests? We can get it merged right away once that's done. Thanks so much for your patience!

@balent
Copy link
Contributor Author

balent commented Sep 2, 2021

Hi @hsimon-hashicorp I've just merged in the latest changes from the main branch. Thanks!

@mladlow mladlow merged commit 3009b50 into hashicorp:main Sep 2, 2021
hashishaw pushed a commit that referenced this pull request Sep 3, 2021
@balent @hashishaw
UI: Show day of month instead of day of year in the expiration warnin…
84f8557 
…g dialog (#11984)

* Show day of month instead of day of year in expiration warning dialog

* Adding changelog
@hashishaw hashishaw mentioned this pull request Sep 3, 2021
Merged
hashishaw added a commit that referenced this pull request Sep 3, 2021
@hashishaw @balent
Backport 1.8.x: UI: Show day of month instead of day of year in the e…
8a34527 
…xpiration warning dialog (#11984) (#12488)

* Show day of month instead of day of year in expiration warning dialog

* Adding changelog

Co-authored-by: Robert Balent <[email protected]>
@heatherezell heatherezell mentioned this pull request Feb 4, 2022
Closed
@heatherezell heatherezell mentioned this pull request Feb 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heatherezell heatherezell heatherezell approved these changes

@hashishaw hashishaw hashishaw approved these changes

@arnav28 arnav28 arnav28 approved these changes

Assignees
No one assigned
Labels
backport bug Used to indicate a potential bug ui
Projects
None yet
Milestone
1.7.5
Development

Successfully merging this pull request may close these issues.

Incorrect expiration date in the UI
7 participants
@balent @hashicorp-cla @zerkms @heatherezell @arnav28 @hashishaw @mladlow