agent/template: add static_secret_render_interval configurable #11934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In case it confuses anyone, |
tvoran
reviewed
Jun 23, 2021
tvoran
reviewed
Jun 24, 2021
Co-authored-by: Theron Voran <[email protected]>
Co-authored-by: Theron Voran <[email protected]>
Co-authored-by: Theron Voran <[email protected]>
tvoran
approved these changes
Jun 24, 2021
jasonodonnell
changed the title
calvn
reviewed
Jun 24, 2021
| @@ -119,7 +119,9 @@ type Sink struct { | |||
|
|
|||
| // TemplateConfig defines global behaviors around template | |||
| type TemplateConfig struct { | |||
| ExitOnRetryFailure bool `hcl:"exit_on_retry_failure"` | |||
| ExitOnRetryFailure bool `hcl:"exit_on_retry_failure"` | |||
| StaticSecretRenderIntRaw interface{} `hcl:"static_secret_render_interval"` | |||
There was a problem hiding this comment.
Did we land/agree on settling with nonleased_secret_render_interval as the param name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consul Template recently added a feature to allow operators to override the default lease duration when a secret has no lease/isn't renewable. This default (5m) can be now altered using the following agent config:
We'll need to add this configurable to both Vault K8s and Vault Helm.