Update cluster status partial to component #11680
Conversation
| @tracked | ||
| fakeRenew = false; | ||
|
|
||
| get isRenewing() { |
| {{#if (and activeCluster.unsealed auth.currentToken)}} | ||
| {{#unless cluster.dr.isSecondary}} | ||
| {{#unless this.version.isOSS}} | ||
| {{#if (and @cluster.unsealed this.auth.currentToken)}} |
There was a problem hiding this comment.
Based on looking at the code, I'm not sure activeCluster as defined on (old) status-menu.js is exactly swappable with currentCluster.cluster which is what's being passed into the component here. My guess is that with the full model (activeCluster) we get the replication info and we may not on the cluster service version, but we'll need to investigate
There was a problem hiding this comment.
I added back the active cluster for now.
In meantime, I will dig further and if required get in touch with Matthew. We can clean up later if required.
There was a problem hiding this comment.
One other check, in case you haven't already, is to run yarn run test -f="enterprise" locally. When we push a branch to OSS it skips all the enterprise test. This area seems to touch some enterprise feature so it's good practice to run those test just in case.
Added back activeCluster Updated changelog
No description provided.