Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update entity-alias.mdx #11629

Merged
merged 2 commits into from
Dec 20, 2021
Merged

Update entity-alias.mdx #11629

merged 2 commits into from
Dec 20, 2021

Conversation

jzck
Copy link
Contributor

@jzck jzck commented May 17, 2021

it was not clear for approle what the name should be the approle name or the role_id.

@hashicorp-cla
Copy link

hashicorp-cla commented May 17, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@yhyakuna yhyakuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

jzck and others added 2 commits August 20, 2021 15:51
it was not clear for approle what the name should be the approle name or the role_id.
Copy link
Contributor

@yhyakuna yhyakuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

Copy link
Contributor

@taoism4504 taoism4504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@mladlow mladlow merged commit 44dadee into hashicorp:main Dec 20, 2021
heppu pushed a commit to heppu/vault that referenced this pull request Jan 13, 2022
* Update entity-alias.mdx

it was not clear for approle what the name should be the approle name or the role_id.

* Update website/content/api-docs/secret/identity/entity-alias.mdx

Co-authored-by: Yoko Hyakuna <[email protected]>

Co-authored-by: Yoko Hyakuna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants