Bug: DB secret engine not showing "Select one" in role select options #11294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnav28
approved these changes
Apr 8, 2021
Monkeychip
added a commit
that referenced
this pull request
Apr 8, 2021
…#11294) * fix issue on mongo db where the select one was not showing * add changelog
catsby
added a commit
that referenced
this pull request
Apr 14, 2021
* master: (78 commits) docs: update vault-helm to 0.11.0 (#11355) Add documentation for vault-csi-provider namespace config (#11344) docs: update vault-k8s to 0.10.0 (#11354) patch(docs): fix link color (#11352) Add TFE/TFC auth plugin to plugin portal (#11348) fix a couple typos (#11343) TLS Diagnose Formatting Fixes (#11342) Add More TLS Tests and Verification of TLS Root Certificate (#11300) Add HA only autopilot to changelog (#11339) Support autopilot when raft is for HA only (#11260) Fixes for db connection file type field (#11331) Fix flakey TestAgent_Template_Retry test (#11332) Darwin/ARM64 build target (#11321) Fix broken OIDC Providers link (#11327) Bug: DB secret engine not showing "Select one" in role select options (#11294) bumping alpine version, improving security (#11271) Run a more strict formatter over the code (#11312) docs: add persistent cache (#11272) Fix a few static analysis findings (#11307) Changing from "changelog" to "release-note" (#11303) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR which addressed another issue, created a bug where because the "Select one" was not showing the Database Secret Engine when creating a role.
I checked the other Secret Engines to confirm this wasn't an issue anywhere else.
Here is the before (notice though it's selected Static, the below fields have not populated because it was by default and not selected which would trigger the fields changing).
Here is the after (notice the fields below will change based on the selection, that was the key issue).
