Add HTTP response headers for hostname and raft node ID (if applicable) #11289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncabatoff
reviewed
Apr 6, 2021
ncabatoff
reviewed
Apr 6, 2021
briankassouf
reviewed
Apr 7, 2021
vishalnayak
reviewed
Apr 7, 2021
vishalnayak
reviewed
Apr 7, 2021
raskchanky
commented
Apr 7, 2021
ncabatoff
reviewed
Apr 8, 2021
ncabatoff
reviewed
Apr 8, 2021
raskchanky
force-pushed
the
api-node-name
branch
from
45ed4bf to
d698f5d
Compare
vishalnayak
reviewed
Apr 9, 2021
command/server/config.go
Outdated
| @@ -68,6 +68,12 @@ type Config struct { | |||
|
|
|||
| DisableSentinelTrace bool `hcl:"-"` | |||
| DisableSentinelTraceRaw interface{} `hcl:"disable_sentinel_trace"` | |||
|
|
|||
| HostnameHeader bool `hcl:"-"` | |||
| HostnameHeaderRaw interface{} `hcl:"hostname_header"` | |||
There was a problem hiding this comment.
When it is a config that is indicating Vault "to do something", we might want to go with using verbs in the names to make them self explanatory. In that sense, we may want to do something like enable_hostname_response_header and enable_raft_node_id_response_header.
This would be inline with disable_mlock, disable_sentinel_trace, disable_clustering, disable_sealwrap and disable_performance_standby.
What do you think?
There was a problem hiding this comment.
Or actually enable_response_header_hostname and enable_response_header_raft_node_id to set the prefix for more response headers we may want to add in future.
There was a problem hiding this comment.
Sure, makes sense. I'll update it.
raskchanky
force-pushed
the
api-node-name
branch
from
ae028e0 to
f58ebce
Compare
raskchanky
added a commit
that referenced
this pull request
Apr 20, 2021
briankassouf
pushed a commit
that referenced
this pull request
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition is the result of a customer request.