-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ServerName to Vault Agent template config #11288
Conversation
@ncabatoff @calvn Any chance we can get this into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and it worked as expected, however, I saw weird behavior where auto-auth would hang indefinitely if a bogus SNI was set. I'm looking deeper into this but don't think this is a blocker on this specific PR.
Holding off on merging as we look into a possible bug uncovered by this. |
@pbar1 We're ready to merge this but a CHANGELOG file for this change is needed. Once added we'll merge and backport this to the 1.7.x branch for the 1.7.2 release. Something like
Thanks! |
Hey, I've been out for a few days. Sure - I'll add that changelog message. |
Co-authored-by: Jason O'Donnell <[email protected]>
* Add ServerName to Vault Agent template config * Remove newline * Add changelog for 11288 * Update changelog/11288.txt Co-authored-by: Jason O'Donnell <[email protected]> Co-authored-by: Jason O'Donnell <[email protected]>
* Add ServerName to Vault Agent template config * Remove newline * Add changelog for 11288 * Update changelog/11288.txt Co-authored-by: Jason O'Donnell <[email protected]> Co-authored-by: Jason O'Donnell <[email protected]> Co-authored-by: Pierce Bartine <[email protected]>
Reopening the closed #9401 here: