-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI/obscure secret on input #11284
Merged
Merged
UI/obscure secret on input #11284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashishaw
suggested changes
Apr 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall! A couple small updates, and I'm going to pull down the branch and try to break it 😁
hashishaw
reviewed
Apr 21, 2021
hashishaw
approved these changes
Apr 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for making these changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a project to Obscure Secret Values on input, and to also obscure certificates on display. There is an option in both of these to toggle on/off the obscured view. To accomplish this, design created a new font called "obscure.woff". We now default to using this font on any input or text-area for either masked-input components and text-file components.
The following are screenshots of places were secrets are now obscured by default:
masked-input @displayOnly=true
Notes:
pgp-file.hbs
component, eventually, we will want to replace this with the text-file component. See start of code here. However, it would require some additional refactoring and be beyond the scope of this project. Currently, this is the only area in the application where you find the upload file but do not see the option to mask/unmask when entering as text.