Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MMMM Do yyyy to MMMM do yyyy per date-fns format docs #11142

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Update MMMM Do yyyy to MMMM do yyyy per date-fns format docs #11142

merged 2 commits into from
Mar 19, 2021

Conversation

chelshaw
Copy link
Contributor

This change corrects the output of the token expiration warning, which was using the key for day of year instead of day of month:

image (1)

@chelshaw chelshaw added ui backport bug Used to indicate a potential bug labels Mar 18, 2021
Monkeychip
Monkeychip approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. There were a lot of small changes like this with the Date fns library update. Doesn't look like I got this one correct.

@vercel vercel bot temporarily deployed to Preview – vault March 18, 2021 21:34 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 18, 2021 21:34 Inactive
@chelshaw chelshaw merged commit 7013fb6 into master Mar 19, 2021
@chelshaw chelshaw deleted the ui/fix-date-format branch March 19, 2021 17:08
chelshaw added a commit that referenced this pull request Mar 19, 2021
@chelshaw
Update MMMM Do yyyy to MMMM do yyyy per date-fns format docs (#11142)
e6c61de 
* Update MMMM Do yyyy to MMMM do yyyy per date-fns format docs

* Add changelog
chelshaw added a commit that referenced this pull request Mar 19, 2021
@chelshaw
Update MMMM Do yyyy to MMMM do yyyy per date-fns format docs (#11142) (…
8c16c80 
…#11154)

* Update MMMM Do yyyy to MMMM do yyyy per date-fns format docs

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
backport bug Used to indicate a potential bug ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chelshaw @Monkeychip