-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for signed GET requests for aws authentication #10961
Conversation
👍🏻 Thank you for working on it. Supporting presigned GET requests is a valuable feature to make integration easier. AWS SDKs offers method to presign requests, but we have to use "internals" in order to catch method/path/headers/body of the sts request. |
Hello, is there any security concern before adding this feature? |
Hey @bluestealth, thanks a lot for your work on this. Kudos for thinking about the tests and docs as well. The code looks sound, my only 2 comments are really minor nitpicking. Do you think it'd be possible to update the branch to resolve the conflict and add a changelog entry so I can have one last look that everything is in order before approving? The changelog could be something like: 10961.txt
|
1781171
to
3c209f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the modification & adding the test case.
Don't worry about the Vercel step, from what I understand it does not work with forks. I validated the doc changes with cd website && make website
and it's ok.
This is required to support presigned requests from aws-sdk-go-v2
This completely slipped under my radar, apologies for the delay and thanks for that contribution! |
Adds support for signed GET requests of GetCallerIdentity for authenticating to vault using the aws iam method.
This is related to aws/aws-sdk-go-v2#1137