-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IAM tagging support for iam_user roles in AWS secret engine #10953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valarissa
force-pushed
the
add_iam_tag_support
branch
from
February 22, 2021 16:55
b27784e
to
d0aca73
Compare
kalafut
reviewed
Feb 22, 2021
kalafut
reviewed
Feb 22, 2021
kalafut
reviewed
Feb 22, 2021
kalafut
reviewed
Feb 22, 2021
Valarissa
force-pushed
the
add_iam_tag_support
branch
from
February 22, 2021 23:33
d0aca73
to
41b5b87
Compare
pcman312
reviewed
Feb 23, 2021
pcman312
approved these changes
Feb 24, 2021
This change allows iam_users generated by the secrets engine to add custom tags in the form of key-value pairs to users that are created.
Valarissa
force-pushed
the
add_iam_tag_support
branch
from
February 25, 2021 23:36
baa29b1
to
ff493ec
Compare
Valarissa
pushed a commit
that referenced
this pull request
Mar 10, 2021
Valarissa
pushed a commit
that referenced
this pull request
Mar 10, 2021
Valarissa
pushed a commit
that referenced
this pull request
Mar 10, 2021
Valarissa
pushed a commit
that referenced
this pull request
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to introduce the ability to add tags to user credentials generated by the AWS secret engine.
Details in usage are provided in the docs that have been updated with this feature, however, for ease of use, the following is an example of adding two tags to a role: