agent: route templating server through cache #10927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
reviewed
Feb 17, 2021
calvn
reviewed
Feb 17, 2021
calvn
reviewed
Feb 18, 2021
calvn
reviewed
Feb 18, 2021
tvoran
reviewed
Feb 18, 2021
Co-authored-by: Theron Voran <[email protected]>
Co-authored-by: Theron Voran <[email protected]>
Co-authored-by: Theron Voran <[email protected]>
Co-authored-by: Theron Voran <[email protected]>
Co-authored-by: Theron Voran <[email protected]>
Co-authored-by: Theron Voran <[email protected]>
tvoran
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the Vault Agent Templating server to support using the local proxy cache. The templating server will automatically configure itself to use the cache if caching is enabled and a listener is present. If either of these requirements aren't satisfied, the templating server will use the
vaultconfiguration as it does today.The only caveat to this change is we ignore TLS verification if the listener has TLS enabled. We do this because a CA would be required to verify the certificate but the proxy and templating server are spawned by the same Vault Agent process.