UI Database Secrets Engine (MongoDB) #10655

Monkeychip · 2021-01-05T19:32:31Z

Adding the Database Secret Engine to the UI. Specifically the MongoDb secret engine.

Screenshots below.

Create Connection

Rotate Root Creds after save on create connection

Static Role creation

View Connection

List Roles and actions

Overview page with full access

Generate Static Role Creds

Generate Dynamic Role Creds

…ose models on routes

…oute

…oute hbs

…Overview tab, but have link to route. It's going be on the secret header list component

…rendered conditionally on secret list header

…orp/vault into ui/database-secrets-engine-enable

backspace

I didn’t do an exhaustive review but I left some comments and observations, hopefully of some use! 💞

ui/app/adapters/database/connection.js

backspace · 2021-02-17T19:06:29Z

ui/app/components/database-list-item.js

+    adapter
+      .rotateRootCredentials(backend, id)
+      .then(() => {
+        this.flashMessages.success(`Success: ${id} connection was reset`);


I guess this is a copypaste error, it should probably be a different message?

The similarity of these two and the ones in components/database-connection makes me wonder whether a utility or somesuch might help DRY this up 🤔

Making a ticket for this.

backspace · 2021-02-17T19:10:25Z

ui/app/components/database-role-setting-form.js

+const STATEMENT_FIELDS = {
+  static: {
+    default: ['creation_statements', 'revocation_statements', 'rotation_statements'],
+    'mongodb-database-plugin': 'NONE', // will not show the section


Would [] work here vs a magic string?

falsey values return an empty state in the template, whereas truthy ones return the form (which iterates over this array). We needed one more state where the state is not empty but we don't want to show the section (Because it's not required for the type of role)... but I think with some refactoring we could probably make an empty array work 🤔

backspace · 2021-02-17T19:13:26Z

ui/app/components/database-role-setting-form.js

+    if (!Array.isArray(fields)) return fields;
+    const filtered = this.args.attrs.filter(a => {
+      const includes = fields.includes(a.name);
+      return includes;


maybe this could be inline vs using an immediately-returned intermediate variable?

const filtered = this.args.attrs.filter(a => fields.includes(a.name));

Even const filtered could maybe be removed in favour of returning the filter call; if the variable name were something more descriptive like argsIncludedInFields it might make sense to preserve as an explanation, but filtered being the result of a call to filter doesn’t tell us much 🤓

Making a ticket for this.

backspace · 2021-02-17T19:23:48Z

ui/app/components/generate-credentials-database.js

+      this.roleType = 'static';
+      return;
+    } catch (error) {
+      errors.push(error.errors);


Have you been able to try this out with real errors? Given the name errors, would it make more sense to append them individually vs pushing an array into the errors array?

but also, maybe nothing is ever done with errors? 😳

Making a ticket for this.

backspace · 2021-02-17T19:58:10Z

ui/app/templates/components/database-role-edit.hbs

+        @buttonClasses="toolbar-link"
+        @onConfirmAction={{action 'delete'}}
+        @confirmTitle="Delete role?"
+        @confirmMessage="This role will be permanently deleted. You will need to re-create it to use it again."


I see some other messages use recreate so maybe it should be here too? 🤔

Making a ticket for this.

backspace · 2021-02-17T20:08:42Z

ui/lib/core/addon/components/form-field.js

@@ -72,6 +72,9 @@ export default Component.extend({
    return '';
  }),

+  // This is only used for `optional-text` editType
+  showInput: false,


Should this be added to the documented arguments at the top?

Making a ticket for this.

backspace · 2021-02-17T20:09:55Z

ui/lib/core/addon/components/info-table-row.js

@@ -33,9 +34,11 @@ export default Component.extend({
  isVisible: or('alwaysRender', 'value'),

  alwaysRender: false,
+  renderBlank: false,


Should this also be documented? I am a non-knower of the conventions here though 😆

Making a ticket for this.

ui/lib/core/addon/components/readonly-form-field.js

ui/lib/core/addon/templates/components/readonly-form-field.hbs

…orp/vault into ui/database-secrets-engine-enable

* master: Adds API docs for max_age role parameter of JWT/OIDC auth method (#10916) UI/Database Secrets Engine cleanup (#10949) helper/metricsutil: Prevent potential Ticker leak (#10913) core/expiration: Add backoff jitter to the expiration retries (#10937) Revert "Vault Dependency Upgrades [VAULT-871] (#10903)" (#10939) Vault Dependency Upgrades [VAULT-871] (#10903) Add docs for Agent's template_retry option added in #10644, based on those from consul-template configuration. Also fix some existing config docs that weren't adhering to our conventions. (#10911) UI Database Secrets Engine (MongoDB) (#10655) OpenAPI - Don't panic if field isn't found (#10929) Vault-1403 Switch Expiration Manager to use Fairsharing Backpressure (#1709) (#10932) Update KV Secrets Engine index (#10933)

Monkeychip added 4 commits January 5, 2021 10:20

move the ttls on enable for db to default and not as options

a323a17

refactor form field to angle brackets

03bd6fe

add database to supported backend

28cd74c

initial setup of components and models

3bf492f

Monkeychip added the ui label Jan 5, 2021

Monkeychip and others added 25 commits January 5, 2021 13:13

setup selectable cards, need to make own component

25d3c23

styling setup

c4aa9ec

subtext and links

205eef2

number styling

267d777

search select put in place and button, all pretty things

04dda6e

search label text

6a0aa33

messy but closer to data configuration. making models and fetching th…

243dc5b

…ose models on routes

connection adapter and serializer that is pulled in by the overview r…

6c9ccff

…oute

clean up and add new model params connections and roles to overview r…

94cd659

…oute hbs

setting up overview as route with SecretHeader component. TODO, show …

4860647

…Overview tab, but have link to route. It's going be on the secret header list component

setup overview tab on secret-list-header to go to overview page

7825c6b

setup id in overview route

37065f2

Correct link on secrets engine list for database and others

66ef64d

Roles tab on database fetches correct model

498a079

Update options for backend with hasOverview param so overview tab is …

c7bc71a

…rendered conditionally on secret list header

create new getCrendentialsComponent

f542d19

Rename database connection parent component and start working on display

7eb626e

Merge branch 'ui/database-secrets-engine-enable' of github.com:hashic…

b0b3b97

…orp/vault into ui/database-secrets-engine-enable

setup routing to credentials route for database from overview page

99bb7df

Merge branch 'ui/database-secrets-engine-enable' of github.com:hashic…

649aa1f

…orp/vault into ui/database-secrets-engine-enable

setup network request for the credentials of role

2ff7a6b

setup serializer for credentials

0f00fa0

redirect previous route

abe15e4

fix border color on button disable

0e50434

add margin to back button

3f495a8

cleanup per comments

d8705d9

vercel bot deployed to Preview – vault-storybook February 17, 2021 18:26 View deployment

vercel bot temporarily deployed to Preview – vault February 17, 2021 18:26 Inactive

backspace reviewed Feb 17, 2021

View reviewed changes

chelshaw added 2 commits February 17, 2021 15:21

fix readonly form field test and lint

38f00ad

Merge branch 'ui/database-secrets-engine-enable' of github.com:hashic…

edd837b

…orp/vault into ui/database-secrets-engine-enable

vercel bot temporarily deployed to Preview – vault February 17, 2021 21:21 Inactive

vercel bot deployed to Preview – vault-storybook February 17, 2021 21:21 View deployment

Cleanup string helpers

a2c1a19

vercel bot deployed to Preview – vault-storybook February 17, 2021 21:34 View deployment

vercel bot temporarily deployed to Preview – vault February 17, 2021 21:34 Inactive

Replace renderBlank with alwaysRender logic

e6c0d64

vercel bot temporarily deployed to Preview – vault February 17, 2021 21:36 Inactive

vercel bot deployed to Preview – vault-storybook February 17, 2021 21:42 View deployment

re-humanize label on readonly form field

5a8feb3

vercel bot temporarily deployed to Preview – vault February 17, 2021 23:10 Inactive

vercel bot deployed to Preview – vault-storybook February 17, 2021 23:10 View deployment

chelshaw added 2 commits February 17, 2021 17:12

Show defaultShown value on info-table-row if no value and always render

2eeb868

Show default on role and connection show table

9355051

vercel bot temporarily deployed to Preview – vault February 17, 2021 23:15 Inactive

vercel bot deployed to Preview – vault-storybook February 17, 2021 23:18 View deployment

chelshaw approved these changes Feb 17, 2021

View reviewed changes

Add changelog

d231248

vercel bot temporarily deployed to Preview – vault February 18, 2021 15:36 Inactive

vercel bot temporarily deployed to Preview – vault-storybook February 18, 2021 15:36 Inactive

chelshaw merged commit 4be76bf into master Feb 18, 2021

chelshaw deleted the ui/database-secrets-engine-enable branch February 18, 2021 16:36

DejfCold mentioned this pull request Aug 24, 2021

PostgreSQL database connections not configurable in UI #12303

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI Database Secrets Engine (MongoDB) #10655

UI Database Secrets Engine (MongoDB) #10655

Monkeychip commented Jan 5, 2021 •

edited

Loading

backspace left a comment

backspace Feb 17, 2021

Monkeychip Feb 17, 2021

backspace Feb 17, 2021

chelshaw Feb 17, 2021

backspace Feb 17, 2021

Monkeychip Feb 17, 2021 •

edited

Loading

backspace Feb 17, 2021

backspace Feb 17, 2021

Monkeychip Feb 17, 2021 •

edited

Loading

backspace Feb 17, 2021

Monkeychip Feb 17, 2021

backspace Feb 17, 2021

Monkeychip Feb 17, 2021

backspace Feb 17, 2021

Monkeychip Feb 17, 2021

UI Database Secrets Engine (MongoDB) #10655

UI Database Secrets Engine (MongoDB) #10655

Conversation

Monkeychip commented Jan 5, 2021 • edited Loading

backspace left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Monkeychip Feb 17, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Monkeychip Feb 17, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Monkeychip commented Jan 5, 2021 •

edited

Loading

Monkeychip Feb 17, 2021 •

edited

Loading

Monkeychip Feb 17, 2021 •

edited

Loading