-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Azure MSI endpoint #10624
Update Azure MSI endpoint #10624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM.
(For others, ref to the new function: adal/token.go)
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 3 out of 4 committers have signed the CLA.
Jim Kalafut seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there! This looks reasonable enough to me. It seems that both of these have been deprecated since, but the suggested change makes it better, as I understand it. I'll see about getting this merged. Sorry that this waited for so long!
Thanks for the contribution!
Update the MSI endpoint appropriate for either App Service or instance metadata. Fixes Azure storage with MSI on App Service.
Fixes #10623