Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fix issue with double encoding on space in secret history route #10596

Merged
merged 6 commits into from
Jan 4, 2021
Merged

Bug: Fix issue with double encoding on space in secret history route #10596

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a4c19a2
setup for concept it works, but probably not the best solution
Monkeychip Dec 16, 2020
a193569
add comment and remove console and test var
Monkeychip Dec 17, 2020
b7b5475
use normalize path higher up to fix issu
Monkeychip Dec 18, 2020
c0dff8e
add test for bug that fixing
Monkeychip Dec 18, 2020
cc5ceba
forgot a couple of changes
Monkeychip Dec 18, 2020
16ff313
changelog
Monkeychip Dec 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ui/app/routes/vault/cluster/secrets/backend/versions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import Route from '@ember/routing/route';
import utils from 'vault/lib/key-utils';
import UnloadModelRoute from 'vault/mixins/unload-model-route';
import { normalizePath } from 'vault/utils/path-encoding-helpers';

export default Route.extend(UnloadModelRoute, {
templateName: 'vault/cluster/secrets/backend/versions',
Expand All @@ -22,6 +23,7 @@ export default Route.extend(UnloadModelRoute, {
model(params) {
let { secret } = params;
const { backend } = this.paramsFor('vault.cluster.secrets.backend');
return this.store.queryRecord('secret-v2', { id: secret, backend });
let id = normalizePath(secret);
return this.store.queryRecord('secret-v2', { id, backend });
},
});