-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helper for encoding/decoding root tokens and OTP generation in SDK module (#10504) #10505
Conversation
26cbf86
to
ab3bfa0
Compare
ab3bfa0
to
857e609
Compare
c136024
to
6ec7615
Compare
6ec7615
to
8dd0eea
Compare
8dd0eea
to
03924d8
Compare
03924d8
to
7ea5624
Compare
b8959f3
to
33a1bf6
Compare
33a1bf6
to
2c851a7
Compare
@ncabatoff hi, I'm back at this, I added all the fixes you suggested. Unfortunately I'm getting some test errors from the rabbitmq part of the code. I will try to debug them today. Is there anything else that this PR needs? |
Merging in the latest main should fix those errors.
A unit test would be nice, but not essential since this is tested indirectly by operator_generate_root_test.go. |
Awesome. I just fixed the changelog and moved back the PGP keys. Waiting for tests to pass 🤞 . Would you like me to squash the commits? |
No need, when I merge it to main I'll be squashing them anyway. |
5a026fb
to
dd21c79
Compare
@ncabatoff thank you very much for your help getting this PR ready for merging. Can I interest you now in a second PR? #10464 |
@ncabatoff can you ✔️ this PR now that we are done with the changes or do we need to get an approval from someone else? |
Thanks for all your hard work @ptzianos ! |
Fixes: #10504
Changes:
Adds: