Only use entropy augmentation for root token creation [VAULT-670] #10487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgmiller
reviewed
Dec 4, 2020
changelog/10487.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ```release-note:bug | |||
| core (enterprise): Instead of all service tokens, only root tokens are generated with entropy augmentation | |||
There was a problem hiding this comment.
This may sound like a risk to users. They may say why wouldn't I want entropy augmentation for all my tokens? I'd reword as "Limit entropy augmentation during token generation to root tokens". It's basically the same thing but doesn't put service tokens straight to mind.
sgmiller
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.