Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port: Add metrics to report mount table sizes for auth and logical [Vault 671] #10201

Merged
merged 12 commits into from
Oct 27, 2020
Merged

Port: Add metrics to report mount table sizes for auth and logical [Vault 671] #10201

merged 12 commits into from
Oct 27, 2020

Conversation

HridoyRoy
Copy link
Contributor

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 20, 2020 •
edited by hashicorp-cla-app bot
Loading

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

1 out of 2 committers have signed the CLA.

  • HridoyRoy
  • Hridoy Roy

Hridoy Roy seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Hridoy Roy and others added 2 commits October 20, 2020 16:08
@HridoyRoy HridoyRoy requested a review from mgritter October 21, 2020 16:48
@HridoyRoy HridoyRoy changed the title Backport: Add metrics to report mount table sizes for auth and logical [Vault 671] Port: Add metrics to report mount table sizes for auth and logical [Vault 671] Oct 21, 2020
mgritter
mgritter reviewed Oct 22, 2020
View reviewed changes
vault/auth_test.go
@@ -323,7 +405,7 @@ func TestCore_DisableCredential_Cleanup(t *testing.T) {
Login: []string{"login"},
BackendType: logical.TypeCredential,
}
c, _, _ := TestCoreUnsealed(t)
c, _, _, _ := TestCoreUnsealedWithMetrics(t)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to fix it in this backport, but I will note that all these changes to the test method could be undone now. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely! I can make a separate PR changing those to TestCoreUnsealed.

@HridoyRoy HridoyRoy merged commit aac17a1 into master Oct 27, 2020
@HridoyRoy HridoyRoy deleted the VAULT-671-backport branch October 27, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgritter mgritter mgritter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HridoyRoy @hashicorp-cla @mgritter