Add plugin reload docs to the website sidebar #10108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should probably be addressed separately, but while looking at #9347 I noticed that value for the |
calvn
reviewed
Oct 7, 2020
| @@ -33,3 +33,6 @@ flags](/docs/commands) included on all commands. | |||
|
|
|||
| - `-mounts` `(array: [])` - Array or comma-separated string mount paths of the | |||
| plugin backends to reload. | |||
|
|
|||
| - `-scope` `(string: "")` - The scope of the reload, omitted for local, 'global' | |||
There was a problem hiding this comment.
Can we re-phrase "omitted for local", as local could it mean mounts, namespaces, or nodes.
There was a problem hiding this comment.
Will do. I just copied what was in the CLI help text. I will adjust that in a later PR after re-wording this one.
There was a problem hiding this comment.
@calvn What are your thoughts on the new phrasing?
rezaaa1359
approved these changes
Oct 11, 2020
ncabatoff
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They weren't in the sidebar, and the
-scopeflag was also missing, so I added that.