Skip to content

Commit

Permalink
Fix delete namespaces (#8132) (#8136)
Browse files Browse the repository at this point in the history
* do not access items.content since it turns items into an InternalModel and breaks deleting namespaces

* remove pagination story until we have a better way to fake data in Storybook
  • Loading branch information
Noelle Daley authored Jan 15, 2020
1 parent a3899b8 commit e5902e5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
2 changes: 1 addition & 1 deletion ui/lib/core/addon/templates/components/list-view.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
)
}}
<div class="box is-fullwidth is-bottomless is-sideless is-paddingless" data-test-list-view-list>
{{#each (or items.content items) as |item|}}
{{#each items as |item|}}
{{yield (hash item=item)}}
{{else}}
{{yield}}
Expand Down
11 changes: 1 addition & 10 deletions ui/lib/core/stories/list-view.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,11 @@ filtered.set('meta', {
total: 100,
});

let paginated = ArrayProxy.create({
content: [{ id: 'middle' }, { id: 'of' }, { id: 'the' }, { id: 'list' }],
});
paginated.set('meta', {
lastPage: 10,
currentPage: 4,
total: 100,
});

// TODO: add a pagination option when we have a better way to fake Ember models in Storybook.
let options = {
list: [{ id: 'one' }, { id: 'two' }],
empty: [],
filtered,
paginated,
};

storiesOf('ListView/', module)
Expand Down

0 comments on commit e5902e5

Please sign in to comment.