UI: Prevent replication disable action from sending data payload (#24292

) * Prevent replication disable action from sending data payload * Add changelog
hashicorp · Nov 29, 2023 · b0ed429 · b0ed429
1 parent 31f399d
commit b0ed429
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/changelog/24292.txt b/changelog/24292.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+ui: Fix payload sent when disabling replication
+```
diff --git a/ui/lib/core/addon/components/replication-action-disable.js b/ui/lib/core/addon/components/replication-action-disable.js
@@ -9,4 +9,11 @@ import layout from '../templates/components/replication-action-disable';
 export default Actions.extend({
   layout,
   tagName: '',
+
+  actions: {
+    onSubmit(replicationMode, clusterMode, evt) {
+      // No data is submitted for disable request
+      return this.onSubmit(replicationMode, clusterMode, null, evt);
+    },
+  },
 });
diff --git a/ui/lib/core/addon/templates/components/replication-action-disable.hbs b/ui/lib/core/addon/templates/components/replication-action-disable.hbs
@@ -31,8 +31,8 @@
   @isActive={{this.isModalActive}}
   @confirmText={{this.model.replicationModeForDisplay}}
   @toConfirmMsg="disabling {{this.model.replicationModeForDisplay}} Replication on this cluster"
-  @onConfirm={{action
-    "onSubmit"
+  @onConfirm={{fn
+    (action "onSubmit")
     "disable"
     (if (eq this.model.replicationAttrs.modeForUrl "bootstrapping") this.mode this.model.replicationAttrs.modeForUrl)
   }}