review feedback

hashicorp · Jan 3, 2020 · a0506cd · a0506cd
1 parent 9a11f0d
commit a0506cd
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/sdk/framework/identity_test.go b/sdk/framework/identity_test.go
@@ -18,20 +18,20 @@ func TestIdentityTemplating(t *testing.T) {
 					MountAccessor: "test_mount",
 					MountType:     "secret",
 					Metadata: map[string]string{
-						"alias-metadata": "metadata-value",
+						"alias-metadata": "alias-metadata-value",
 					},
 				},
 			},
 			Metadata: map[string]string{
-				"entity-metadata": "metadata-value",
+				"entity-metadata": "entity-metadata-value",
 			},
 		},
 		GroupsVal: []*logical.Group{
 			{
 				ID:   "group1-id",
 				Name: "group1",
 				Metadata: map[string]string{
-					"group-metadata": "metadata-value",
+					"group-metadata": "group-metadata-value",
 				},
 			},
 		},
@@ -51,7 +51,7 @@ func TestIdentityTemplating(t *testing.T) {
 		},
 		{
 			tpl:      "{{identity.entity.metadata.entity-metadata}}",
-			expected: "metadata-value",
+			expected: "entity-metadata-value",
 		},
 		{
 			tpl:      "{{identity.entity.aliases.test_mount.id}}",
@@ -67,7 +67,7 @@ func TestIdentityTemplating(t *testing.T) {
 		},
 		{
 			tpl:      "{{identity.entity.aliases.test_mount.metadata.alias-metadata}}",
-			expected: "metadata-value",
+			expected: "alias-metadata-value",
 		},
 		{
 			tpl:      "{{identity.groups.ids.group1-id.name}}",
@@ -79,11 +79,11 @@ func TestIdentityTemplating(t *testing.T) {
 		},
 		{
 			tpl:      "{{identity.groups.names.group1.metadata.group-metadata}}",
-			expected: "metadata-value",
+			expected: "group-metadata-value",
 		},
 		{
 			tpl:      "{{identity.groups.ids.group1-id.metadata.group-metadata}}",
-			expected: "metadata-value",
+			expected: "group-metadata-value",
 		},
 	}
 

diff --git a/sdk/plugin/pb/backend.pb.go b/sdk/plugin/pb/backend.pb.go
diff --git a/sdk/plugin/pb/backend.proto b/sdk/plugin/pb/backend.proto
@@ -600,7 +600,7 @@ service SystemView {
 	// PluginEnv returns Vault environment information used by plugins
 	rpc PluginEnv(Empty) returns (PluginEnvReply);
 
-	// GroupsForEntity returns the group membersship information for the given
+	// GroupsForEntity returns the group membership information for the given
 	// entity id
 	rpc GroupsForEntity(EntityInfoArgs) returns (GroupsForEntityReply);
 }