ToUpper base32 values for TOTP key ingress (#6400)

Fixes #6396
hashicorp · Mar 12, 2019 · 8b9c1e2 · 8b9c1e2
1 parent a94a4b8
commit 8b9c1e2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/builtin/logical/totp/backend_test.go b/builtin/logical/totp/backend_test.go
@@ -6,6 +6,7 @@ import (
 	"log"
 	"net/url"
 	"path"
+	"strings"
 	"testing"
 	"time"
 
@@ -25,7 +26,7 @@ func createKey() (string, error) {
 
 	key := keyUrl.Secret()
 
-	return key, err
+	return strings.ToLower(key), err
 }
 
 func generateCode(key string, period uint, digits otplib.Digits, algorithm otplib.Algorithm) (string, error) {

diff --git a/builtin/logical/totp/path_keys.go b/builtin/logical/totp/path_keys.go
@@ -375,7 +375,7 @@ func (b *backend) pathKeyCreate(ctx context.Context, req *logical.Request, data
 			return logical.ErrorResponse("the key value is required"), nil
 		}
 
-		_, err := base32.StdEncoding.DecodeString(keyString)
+		_, err := base32.StdEncoding.DecodeString(strings.ToUpper(keyString))
 		if err != nil {
 			return logical.ErrorResponse(fmt.Sprintf(
 				"invalid key value: %s", err)), nil