Skip to content

Commit

Permalink
UI: fix bug where users couldn't nav back to unwrapped data (#6404)
Browse files Browse the repository at this point in the history
* fix bug where users couldn't nav back to unwrapped data

* don't autocomplete wrapped token input on unwrap page
  • Loading branch information
meirish authored Mar 13, 2019
1 parent a1ebacc commit 6e73c7e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
5 changes: 3 additions & 2 deletions ui/app/templates/partials/tools/unwrap.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
<nav class="tabs">
<ul>
<li role="tab" aria-selected={{if (eq unwrapActiveTab "data") "true" "false"}} class="{{if (eq unwrapActiveTab "data") "is-active"}}">
<button class="link link-plain tab has-text-weight-semibold" {{action (mut unwrapActiveTab)}}>Data</button>
<button class="link link-plain tab has-text-weight-semibold" {{action (mut unwrapActiveTab) "data"}} data-test-button-data>Data</button>
</li>
<li role="tab" aria-selected={{if (eq unwrapActiveTab "data") "true" "false"}} class="{{if (eq unwrapActiveTab "details") "is-active"}}">
<button class="link link-plain tab has-text-weight-semibold" {{action (mut unwrapActiveTab) "details"}}>Wrap Details</button>
<button class="link link-plain tab has-text-weight-semibold" {{action (mut unwrapActiveTab) "details"}} data-test-button-details>Wrap Details</button>
</li>
</ul>
</nav>
Expand Down Expand Up @@ -75,6 +75,7 @@
class="input"
id="token"
name="token"
autocomplete="off"
data-test-tools-input="wrapping-token"
}}
</div>
Expand Down
3 changes: 3 additions & 0 deletions ui/tests/acceptance/tools-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,9 @@ module('Acceptance | tools', function(hooks) {
JSON.parse(DATA_TO_WRAP),
'unwrapped data equals input data'
);
await click('[data-test-button-details]');
await click('[data-test-button-data]');
assert.dom('.CodeMirror').exists();

//random
await click('[data-test-tools-action-link="random"]');
Expand Down

0 comments on commit 6e73c7e

Please sign in to comment.