Call out nil return for now

audit/entry_formatter.go

@@ -261,6 +261,8 @@ func clone[V any](s V) (V, error) {
 // an audit Auth.
 // tokenRemainingUses should be the client token remaining uses to include in auth.
 // This usually can be found in logical.Request.ClientTokenRemainingUses.
+// NOTE: Will return nil auth and error if the supplied auth is nil.
+// The caller should check the returned value for nil before using it.
 func newAuth(auth *logical.Auth, tokenRemainingUses int) (*Auth, error) {
 	if auth == nil {
 		return nil, nil
@@ -336,6 +338,8 @@ func newAuth(auth *logical.Auth, tokenRemainingUses int) (*Auth, error) {
 
 // newRequest takes a logical.Request and namespace.Namespace, transforms and
 // aggregates them into an audit Request.
+// NOTE: Will return nil request and error if the supplied request is nil.
+// The caller should check the returned value for nil before using it.
 func newRequest(req *logical.Request, ns *namespace.Namespace) (*Request, error) {
 	if req == nil {
 		return nil, nil
@@ -397,6 +401,8 @@ func newRequest(req *logical.Request, ns *namespace.Namespace) (*Request, error)
 // newResponse takes a logical.Response and logical.Request, transforms and
 // aggregates them into an audit Response.
 // isElisionRequired is used to indicate that response 'Data' should be elided.
+// NOTE: Will return nil response and error if the supplied response is nil.
+// The caller should check the returned value for nil before using it.
 func newResponse(resp *logical.Response, req *logical.Request, isElisionRequired bool) (*Response, error) {
 	if resp == nil {
 		return nil, nil
@@ -538,7 +544,7 @@ func (f *entryFormatter) createEntry(ctx context.Context, a *AuditEvent) (*Entry
 
 	var resp *Response
 	if a.Subtype == ResponseType {
-		shouldElide := f.config.elideListResponses && req.Operation == logical.ListOperation
+		shouldElide := f.config.elideListResponses && req != nil && req.Operation == logical.ListOperation
 		resp, err = newResponse(data.Response, data.Request, shouldElide)
 		if err != nil {
 			return nil, fmt.Errorf("cannot convert request: %w", err)