-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Co-authored-by: miagilepner <[email protected]>
- Loading branch information
1 parent
bef8a3a
commit 5cb6a88
Showing
9 changed files
with
122 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
```release-note:bug | ||
core (enterprise): Fix a deadlock that can occur on performance secondary clusters when there are many mounts and a mount is deleted or filtered | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
website/content/partials/known-issues/perf-secondary-many-mounts-deadlock.mdx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
### Deadlock can occur on performance secondary clusters with many mounts | ||
|
||
#### Affected versions | ||
|
||
- 1.15.0 - 1.15.5 | ||
- 1.14.5 - 1.14.9 | ||
- 1.13.9 - 1.13.13 | ||
|
||
#### Issue | ||
|
||
Vault 1.15.0, 1.14.5, and 1.13.9 introduced a worker pool to schedule periodic | ||
rollback operations on all mounts. This worker pool defaulted to using 256 | ||
workers. The worker pool introduced a risk of deadlocking on the active node of | ||
**performance secondary clusters**, leaving that cluster unable to service any | ||
requests. | ||
|
||
The conditions required to cause the deadlock on the performance secondary: | ||
|
||
- Performance replication is enabled | ||
- The performance primary cluster has more than 256 non-local mounts. The more | ||
mounts the cluster has, the more likely the deadlock becomes | ||
- One of the following occurs: | ||
- A replicated mount is unmounted or remounted OR | ||
- A replicated namespace is deleted OR | ||
- Replication paths filters are used to filter at least one mount or namespace | ||
|
||
#### Workaround | ||
|
||
Set the `VAULT_ROLLBACK_WORKERS` environment variable to a number larger than | ||
the number of mounts in your Vault cluster and restart Vault: | ||
|
||
```shell-session | ||
$ export VAULT_ROLLBACK_WORKERS=1000 | ||
``` |