Go's SSH library can panic without warning; recover.

Ping #2877 -- but don't close yet in case there are more places.
hashicorp · Jun 16, 2017 · 0ee100e · 0ee100e
1 parent aab867a
commit 0ee100e
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/builtin/logical/ssh/path_sign.go b/builtin/logical/ssh/path_sign.go
@@ -383,7 +383,16 @@ func (b *backend) calculateTTL(data *framework.FieldData, role *sshRole) (time.D
 	return ttl, nil
 }
 
-func (b *creationBundle) sign() (*ssh.Certificate, error) {
+func (b *creationBundle) sign() (retCert *ssh.Certificate, retErr error) {
+	defer func() {
+		if r := recover(); r != nil {
+			err, ok := r.(error)
+			if ok {
+				retErr = err
+			}
+		}
+	}()
+
 	serialNumber, err := certutil.GenerateSerialNumber()
 	if err != nil {
 		return nil, err