Skip to content

Commit

Permalink
Remove deprecated core-js version from production builds (#15898)
Browse files Browse the repository at this point in the history
* updates deps and build to exclude deprecated core-js version and adds eslint compatibility plugin

* removes eslint compat plugin config from eslintrc and updates browserslistrc targets

* adds changelog entry
  • Loading branch information
zofskeez authored Jun 9, 2022
1 parent a7111c5 commit 05f9202
Show file tree
Hide file tree
Showing 6 changed files with 1,206 additions and 71 deletions.
3 changes: 3 additions & 0 deletions changelog/15898.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
ui: Removed deprecated version of core-js 2.6.11
```
7 changes: 4 additions & 3 deletions ui/.browserslistrc
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
defaults
not IE 11
maintained node versions
last 1 chrome version
last 1 firefox version
last 1 safari version
last 1 edge version
7 changes: 6 additions & 1 deletion ui/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,12 @@ module.exports = {
},
},
plugins: ['ember'],
extends: ['eslint:recommended', 'plugin:ember/recommended', 'plugin:prettier/recommended'],
extends: [
'eslint:recommended',
'plugin:ember/recommended',
'plugin:prettier/recommended',
'plugin:compat/recommended',
],
env: {
browser: true,
},
Expand Down
7 changes: 2 additions & 5 deletions ui/ember-cli-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const config = require('./config/environment')();
const environment = EmberApp.env();
const isProd = environment === 'production';
const isTest = environment === 'test';
const isCI = !!process.env.CI;
// const isCI = !!process.env.CI;

const appConfig = {
'ember-service-worker': {
Expand All @@ -30,10 +30,7 @@ const appConfig = {
},
},
babel: {
plugins: ['@babel/plugin-proposal-object-rest-spread', ['inline-json-import', {}]],
},
'ember-cli-babel': {
includePolyfill: isTest || isProd || isCI,
plugins: [['inline-json-import', {}]],
},
hinting: isTest,
tests: isTest,
Expand Down
6 changes: 3 additions & 3 deletions ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"deepmerge": "^4.0.0",
"doctoc": "^1.4.0",
"ember-api-actions": "^0.2.8",
"ember-auto-import": "^1.12.0",
"ember-auto-import": "2.4.2",
"ember-basic-dropdown": "4.0.3",
"ember-cli": "~3.28.5",
"ember-cli-autoprefixer": "^0.8.1",
Expand All @@ -96,7 +96,6 @@
"ember-cli-content-security-policy": "^1.0.0",
"ember-cli-dependency-checker": "^3.2.0",
"ember-cli-deprecation-workflow": "^2.1.0",
"ember-cli-element-closest-polyfill": "^0.0.1",
"ember-cli-flash": "^1.7.2",
"ember-cli-htmlbars": "^5.7.2",
"ember-cli-inject-live-reload": "^2.1.0",
Expand All @@ -118,7 +117,6 @@
"ember-inflector": "4.0.2",
"ember-link-action": "^1.0.0",
"ember-load-initializers": "^2.1.2",
"ember-maybe-import-regenerator": "^0.1.6",
"ember-maybe-in-element": "^2.0.3",
"ember-modal-dialog": "4.0.0",
"ember-modifier": "^3.1.0",
Expand All @@ -142,6 +140,7 @@
"escape-string-regexp": "^2.0.0",
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-compat": "4.0.2",
"eslint-plugin-ember": "^10.5.8",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-prettier": "^3.4.1",
Expand Down Expand Up @@ -171,6 +170,7 @@
"swagger-ui-dist": "^3.36.2",
"text-encoder-lite": "2.0.0",
"walk-sync": "^2.0.2",
"webpack": "5.73.0",
"xstate": "^3.3.3"
},
"optionalDependencies": {
Expand Down
Loading

0 comments on commit 05f9202

Please sign in to comment.