Add OOM integration test #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous client cache locking scheme was not thread safe, and allocated more locks than are typically needed. This change replaces that approach by using the KeyMutex provided by the k8s utils package. Locks are now a pooled resource. Other fixes - update invalid Bitnami Helm chart repo for postgres. We should phasing out its use. - Bump TF Helm to latest version
Previously, VSO was caching and registering full object watchers on K8s Secrets. While watching K8s Secrets is necessary for automated remediation in the case where a destination secret is deleted from the cluster, doing so can result in OOM conditions for the operator, since each Secret's data contributes to the operator's total memory. This change does the following: - disables the caching K8s Secrets in the manager's client. - only watches for Secret metadata changes.
benashz
force-pushed
the
VAULT-32632/add-oom-integration-tests
branch
from
6c7ab63 to
6a29244
Compare
Ensure that we are always testing against the previous enterprise releases. Community lags behind those release, so we only test against enterprise on the N-1, and N-2 versions.
tvoran
approved these changes
Dec 10, 2024
Base automatically changed from
VAULT-32632/fix-secrets-memory-usage
to
main
December 10, 2024 22:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds dedicated integration tests to ensure that manager is not OOM killed when the total K8s Secret data exceeds the container's memory limits.
To run: