Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set VaultConnection headers on the vault client #629

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Set VaultConnection headers on the vault client #629

merged 4 commits into from
Mar 6, 2024

Conversation

tvoran
Copy link
Member

@tvoran tvoran commented Feb 29, 2024

Set Vault client headers from VaultConnection.Spec.Headers.

Fixes #622

@tvoran tvoran added this to the v0.5.2 milestone Feb 29, 2024
@tvoran tvoran requested a review from a team as a code owner February 29, 2024 01:49
@benashz benashz self-requested a review March 4, 2024 14:53
tomhjp
tomhjp approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

benashz
benashz approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I added a suggestion to ensure that the Vault namespace from config always takes precedence over. We may also want to warn in the case where X-Vault-Namespace is being set in the custom headers. We could also make setting that header illegal.

internal/vault/config.go Show resolved Hide resolved
internal/vault/config_test.go Show resolved Hide resolved
@tvoran
Copy link
Member Author

tvoran commented Mar 6, 2024

Thanks!

@tvoran tvoran enabled auto-merge (squash) March 6, 2024 07:18
@tvoran tvoran merged commit 21d7615 into main Mar 6, 2024
12 checks passed
@tvoran tvoran deleted the VAULT-24346/use-vaultconnection-headers branch March 6, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

@tomhjp tomhjp tomhjp approved these changes

@thyton thyton thyton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.2
Development

Successfully merging this pull request may close these issues.

VSO failed to connect through CloudFlare Zero Trust
4 participants
@tvoran @tomhjp @thyton @benashz