-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IAM EC2 auth #161
Merged
evanphx
merged 21 commits into
hashicorp:master
from
maschwenk:feature.add-ec2-iam-auth
Feb 27, 2018
Merged
Add IAM EC2 auth #161
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
4432283
Add IAM EC2 auth
maschwenk b70de61
Service needs to be STS. Provide session token from credentials API
maschwenk 78c05e9
Make Vault header optional
maschwenk 60f70e2
Split ECS/EC2 into seperate public methods delegating to single priva…
maschwenk 7602166
Provide a CrendentialsProvider and region instead of complex metadata…
maschwenk 75fd1b0
Fix header name
maschwenk cc1365b
Replace hard-coded region with STS endpoint from which region is deri…
maschwenk 128fdef
Remove canary header
maschwenk e598ffc
Add note about Beijing STS endpoint
maschwenk 98ddc19
Reorder params to have least likely to be overriden as the last
maschwenk 11a5cde
Correct wrong var name
maschwenk 6217a9f
Add a mocked out integration test
maschwenk 370d7e0
Adjust documentation of header value
maschwenk d23372a
Escape the period because it's actually part of the url
maschwenk d8357d4
Split region method into seperate method so it can be easily unit tested
maschwenk 1321c11
Formal doc
maschwenk 1a57422
Add canary header to integration test
maschwenk 9f4ff2f
Unit test for url parsing
maschwenk ca17bac
Fix documentation
maschwenk 43e211d
Properly test iam header check
maschwenk 63a54f7
Fix documentation method name
maschwenk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
require "spec_helper" | ||
|
||
module Vault | ||
describe Authenticate do | ||
let(:auth) { Authenticate.new(client: nil) } | ||
describe "#region_from_sts_endpoint" do | ||
subject { auth.send(:region_from_sts_endpoint, sts_endpoint) } | ||
|
||
context 'with a china endpoint' do | ||
let(:sts_endpoint) { "https://sts.cn-north-1.amazonaws.com.cn" } | ||
it { is_expected.to eq 'cn-north-1' } | ||
end | ||
|
||
context 'with a GovCloud endpoint' do | ||
let(:sts_endpoint) { "https://sts.us-gov-west-1.amazonaws.com" } | ||
it { is_expected.to eq 'us-gov-west-1' } | ||
end | ||
|
||
context 'with no regional endpoint' do | ||
let(:sts_endpoint) { "https://sts.amazonaws.com" } | ||
it { is_expected.to eq 'us-east-1' } | ||
end | ||
|
||
context 'with a malformed url' do | ||
let(:sts_endpoint) { "https:sts.amazonaws.com" } | ||
it { expect { subject }.to raise_exception(StandardError, "Unable to parse STS endpoint https:sts.amazonaws.com") } | ||
end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this expectation could obviate the need for the comment in e598ffc