config endpoint implementation #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhjp
approved these changes
Apr 14, 2022
path_config.go
Outdated
Comment on lines
139
to
141
| if config.DisableLocalCAJwt && config.CACert == "" { | ||
| return logical.ErrorResponse("kubernetes_ca_cert must be given when disable_local_ca_jwt is true"), nil | ||
| } |
There was a problem hiding this comment.
There is a fairly popular issue in the auth repo to get rid of this requirement: hashicorp/vault-plugin-auth-kubernetes#62
I think it should be ok to just skip it, and assume that the API is either safely exposed over HTTP (some kind of lower layer network encryption/authentication via VPN/proxy), or uses a publicly trusted CA like for AWS ELBs.
There was a problem hiding this comment.
Makes sense to me, removed in 7cbb6b3.
Co-authored-by: Tom Proctor <[email protected]>
Co-authored-by: Tom Proctor <[email protected]>
…-secrets-kubernetes into VAULT-5669/config
Also check for k8s env vars if the host isn't set during config write.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements the config endpoint for the secrets engine.
Design of Change
Adds config parameters to the backend:
kubernetes_host (string: ""): Kubernetes API URL to connect to. Defaults tohttps://$KUBERNETES_SERVICE_HOST:KUBERNETES_SERVICE_PORT_HTTPSif those environment variables are set.service_account_jwt (string: ""): The JSON web token of the service account used by the secret engine to manage Kubernetes roles. Defaults to the local pod’s JWT if found.kubernetes_ca_cert (string: ""): PEM encoded CA certificate to use by the secret engine to verify the Kubernetes API server certificate. Defaults to the local pod’s CA if found.disable_local_ca_jwt (bool: false): Disable defaulting to the local CA certificate and service account JWT when running in a Kubernetes pod.Uses the caching file reader introduced in https://github.com/hashicorp/vault-plugin-auth-kubernetes for reading the local pod's JWT and CA.
Related Issues/Pull Requests
Depends on:
Contributor Checklist
TODO: