Add display attributes for OpenAPI OperationID's #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averche
changed the title
AnPucel
reviewed
Apr 12, 2023
| logical.DeleteOperation: &framework.PathOperation{ | ||
| Callback: withFieldValidator(b.pathKeysTrimWrite), | ||
| DisplayAttrs: &framework.DisplayAttributes{ | ||
| OperationSuffix: "key-versions2", |
There was a problem hiding this comment.
Does this need to have 2 appended? I don't see the duplicate
There was a problem hiding this comment.
These two are colliding:
| Path | Method | OperationID |
|---|---|---|
| "/{gcpkms_mount_path}/keys/trim/{key}" | "post" | "google-cloud-kms-trim-key-versions" |
| "/{gcpkms_mount_path}/keys/trim/{key}" | "delete" | "google-cloud-kms-trim-key-versions2" |
AnPucel
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The display attributes added in this PR will be translated into OperationID's in vault-generated OpenAPI documents (when calling
/sys/internal/specs/openapiwith this plugin enabled). The OperationID's will, in turn, be translated into function / method names in generated OpenAPI-based libraries (e.g. hashicorp/vault-client-go & hashicorp/vault-client-dotnet).This PR will introduce the following OperationIDs:
Related Issues/Pull Requests