Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for v0.19.0 release #214

Merged
merged 1 commit into from
May 21, 2024
Merged

Prepare for v0.19.0 release #214

merged 1 commit into from
May 21, 2024
+12 −0

Conversation

vinay-gopalan
Copy link
Contributor

No description provided.

@vinay-gopalan vinay-gopalan requested a review from a team May 21, 2024 20:22
@kpcraig
Copy link

kpcraig commented May 21, 2024

what a weird set of errors

@vinay-gopalan
Copy link
Contributor Author

Adding a note here for reference that the errors in build are expected. The make generate target has been broken and upgrading to Go1.21 highlights that in the build with the toolchain directive. There is a draft PR #211 open to fix this. For now, manual acceptance tests, unit tests and builds (external and built-in) were used to confirm that the secrets engine works as expected.

@vinay-gopalan vinay-gopalan merged commit 92f5331 into main May 21, 2024
2 of 3 checks passed
@vinay-gopalan vinay-gopalan deleted the VAULT-27282/changelog-0.19.0 branch May 21, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpcraig kpcraig kpcraig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinay-gopalan @kpcraig