WIF support for GCP secrets engine #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinay-gopalan
changed the title
fairclothjm
reviewed
Apr 22, 2024
fairclothjm
approved these changes
Apr 29, 2024
vinay-gopalan
commented
May 9, 2024
| @@ -1,7 +1,7 @@ | |||
| // Copyright (c) HashiCorp, Inc. | |||
| // SPDX-License-Identifier: MPL-2.0 | |||
|
|
|||
| //go:generate go run internal/generate_resources.go | |||
| //go:generate go run github.com/hashicorp/vault-plugin-secrets-gcp/plugin/iamutil/internal/ | |||
There was a problem hiding this comment.
It doesn't look like this ever worked 🤔 Upon upgrading to Go 1.21+, the inclusion of the toolchain directive seems to have uncovered this issue. The incorrect path was breaking tests once the Go version was upgraded, and after meeting with @tomhjp, we decided that using the full path to the underlying directory is the better way to generate and import these resources.
|
The build failures are expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds plugin WIF support to the GCP secrets engine. This adds the following new fields to the config endpoint to enable configuring Workload Identity Federation:
identity_token_audienceidentity_token_ttlservice_account_emailThe PR also adds tests to ensure that these fields can be set/read to the config and that providing mutually exclusive fields results in an error both against CE and Enterprise editions.
The PR also adds the
PluginIdentityTokenSupplierCredential Provider that fetches a plugin identity token from Vault and passes it to an external account Token Source for a valid federated credential exchange. The full functionality of this feature is linked to this PR on thego-gcp-common: hashicorp/go-gcp-common#14, and will be available when those updates are merged and pulled into this repository.