Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcp_roleset are not updated when scopes change #45

Closed
fraenkel opened this issue Aug 9, 2019 · 0 comments · Fixed by #90
Closed

gcp_roleset are not updated when scopes change #45

fraenkel opened this issue Aug 9, 2019 · 0 comments · Fixed by #90

Comments

@fraenkel
Copy link

fraenkel commented Aug 9, 2019

If one changes the scopes for a vault_gcp_secret_roleset, the code will not update the scopes.

https://github.com/hashicorp/vault-plugin-secrets-gcp/blob/master/plugin/path_role_set.go#L343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update token scopes even when bindings aren't being changed dhduvall/vault-plugin-secrets-gcp
1 participant
@fraenkel