correct msgraph search query - fixes #189 #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@vinay-gopalan any chance you could review / merge this one? |
This was referenced May 2, 2024
|
@sspans-sbp I found the same bug while working on something else. Agree that it's only in Vault 1.16+. There's also a |
|
A better solution was merged in #200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The refactored validation for static service principals was checking the application_object_id by searching for an application_id. This updates the search to search for application_object_id instead.
Design of Change
Only the search filter was updated.
The lookup could possibly be improved by fetching the application object directly rather than searching. But in this case I've opted for the smallest change to resolve the regression.
Related Issues/Pull Requests
[x] Issue #189
Contributor Checklist
[ ] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
My Docs PR Link
Example
[ ] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
[x] Backwards compatible