prepare changelog for v0.17.1 #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah thanks for pointing that out, completely missed that! Going to close this and add a comment on #186 to include the updates from here |
Merged
|
We have decided to move forward with the v0.17.1 release with just the panic fix in #191. This PR has been reopened for review |
Zlaticanin
approved these changes
Apr 18, 2024
tomhjp
approved these changes
Apr 18, 2024
vinay-gopalan
added a commit
that referenced
this pull request
Apr 18, 2024
tomhjp
reviewed
Apr 18, 2024
| ## v0.17.1 | ||
|
|
||
| BUG FIXES: | ||
| * Add nil check for response when unassigning roles [[GH-191]](https://github.com/hashicorp/vault-plugin-secrets-azure/pull/191) |
There was a problem hiding this comment.
Looks like my comment got lost somehow. The suggestion I had meant to leave was to phrase this more directly in terms of impact users will see, e.g. "Avoid panic when unassigning roles", but it's very minor and not worth opening up another PR for 👍 I only wanted my review comment to make sense :-)
vinay-gopalan
added a commit
that referenced
this pull request
Apr 18, 2024
tomhjp
added a commit
that referenced
this pull request
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.