Flatten check-out handlers #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrannosaurus-becks
requested review from
kalafut,
malnick,
jasonodonnell and
catsby
kalafut
reviewed
Oct 8, 2019
kalafut
reviewed
Oct 8, 2019
kalafut
reviewed
Oct 8, 2019
kalafut
reviewed
Oct 8, 2019
tyrannosaurus-becks
changed the base branch from
add-checkout-endpoints
to
feature-ad-credential-checkout
tyrannosaurus-becks
force-pushed
the
checkout-handlers-and-races
branch
from
b89b4fa to
0185f1e
Compare
tyrannosaurus-becks
added a commit
that referenced
this pull request
Oct 10, 2019
* change readConfig from a method to a function (#39) * Add storage handler (#41) * add storage handler * changes from feedback * add validateInputs func and tests * fix comment indentation * comment all exported items * fix comment indentation * Add password handler (#43) * add password handler * add ErrNotFound * fix build ooms (#46) * Add reserve API endpoints (#47) * fix test edits that were for debugging (#48) * Add checkout status endpoint (#50) * add checkout status endpoint * only return the available field if its checked in * order imports * Add enforcement toggle (#49) * add enforcement toggle * add more tests * replace lending period with ttl and max ttl (#51) * Rename reserve to set (#52) * rename reserve to set * update test err * remove dupe ttl lines * Add check-out, check-in, renewal, revocation, and race protection (#53) * flatten check-out handler (#54) * finish replacing Reserve with Set * Fixes from testing (#56) * error loudly on unauthorized check-ins * 400 when check-outs are unavailable * make check-ins an empty array when none are executed * dont error if someone tries to check in an account already in * Update plugin/path_checkouts.go Co-Authored-By: Jim Kalafut <[email protected]> * log and count when check-outs are unavailable (#57)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
CheckOutHandlerinterface with a struct by the same name.StorageHandlerand thePasswordHandleronto that struct.validateInputsfunc with inline input validation because it seemed that less indirection was desired; however, happy to add it back if that's preferable.checkout_handlers.go(plural) tocheckout_handler.go(singular), which makes it look like more code change than it is.This PR is really just a bunch of code being moved around, it doesn't change anything or introduce anything new.
TODO (separate PR)