-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiplexing support #74
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairclothjm
force-pushed
the
multiplexing
branch
from
January 26, 2022 21:52
a566259
to
7bec26a
Compare
jasonodonnell
previously approved these changes
Feb 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that multiplexing is merged, can we update go.mod
to point to it so it builds?
jasonodonnell
previously approved these changes
Feb 17, 2022
Need to wait for the vault sdk to be released. Then update the PR to point to the new sdk and can merge this PR. |
jasonodonnell
approved these changes
Feb 25, 2022
calvn
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add multiplexing support to the Oracle db plugin.
This is pointing to a pseudo tag on the vault repo. Steps taken to update go.mod:
go get github.com/hashicorp/vault/sdk@sdk/v0.4.0
go mod tidy
Test
To test this out take the following steps: