Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiplexing support #74

Merged
merged 5 commits into from
Feb 25, 2022
Merged

Add multiplexing support #74

merged 5 commits into from
Feb 25, 2022

Conversation

fairclothjm
Copy link
Contributor

@fairclothjm fairclothjm commented Jan 20, 2022

Description

Add multiplexing support to the Oracle db plugin.

This is pointing to a pseudo tag on the vault repo. Steps taken to update go.mod:

  • go get github.com/hashicorp/vault/sdk@sdk/v0.4.0
  • go mod tidy

Test

To test this out take the following steps:

  • run oracle DB
  • checkout this branch
  • build oracle plugin
  • build vault with vault main branch
  • run vault

jasonodonnell
jasonodonnell previously approved these changes Feb 17, 2022
Copy link

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that multiplexing is merged, can we update go.mod to point to it so it builds?

jasonodonnell
jasonodonnell previously approved these changes Feb 17, 2022
@fairclothjm
Copy link
Contributor Author

Need to wait for the vault sdk to be released. Then update the PR to point to the new sdk and can merge this PR.

@fairclothjm fairclothjm merged commit f41d3fb into master Feb 25, 2022
@fairclothjm fairclothjm deleted the multiplexing branch February 25, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants