Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add display attributes necessary to create kubernetes roles in the ui #71

Merged
merged 1 commit into from
Dec 3, 2019
Merged

add display attributes necessary to create kubernetes roles in the ui #71

merged 1 commit into from
Dec 3, 2019

Conversation

andaley
Copy link
Contributor

@andaley andaley commented Sep 26, 2019 •
edited
Loading

This PR sets the display attributes so we can use OpenApi to generate the CRUD views for kubernetes roles in the UI.

Don't merge this until hashicorp/vault#7513 is merged!

@jasonodonnell jasonodonnell self-requested a review December 3, 2019 17:42
jasonodonnell
jasonodonnell approved these changes Dec 3, 2019
View reviewed changes
Copy link

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with @noelledaley and this is ready to be merged.

@jasonodonnell jasonodonnell merged commit f4ed471 into master Dec 3, 2019
@jasonodonnell jasonodonnell deleted the ui/add-ui-fields-role branch December 3, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonodonnell jasonodonnell jasonodonnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andaley @jasonodonnell