Add OIDC provider for IBM ISAM #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@godvoigt - Are you able to sign the CLA? |
|
@austingebauer Yes I signed it, but the status here is somehow not updated. If I click on "Recheck it", I am only redirected to my Github profile. |
ghost
mentioned this pull request
|
@austingebauer The CLA is fine now :-) |
austingebauer
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds a custom provider to support IBM ISAM style group claims, which are basically a space separated string of group names. It is nearly identical to the SecureAuth provider, so refactoring common code might sense.
Design of Change
Creating a custom provider was enough to get the connection to our instance of IBM ISAM working.
Related Issues/Pull Requests
Contributor Checklist
[x] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
IBM ISAM Provider Docs PR
[?] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
[x] Backwards compatible