Validate JWT supported algorithms against supported set if not provided in config #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
reviewed
Mar 15, 2021
Co-authored-by: Calvin Leung Huang <[email protected]>
calvn
approved these changes
Mar 15, 2021
kalafut
approved these changes
Mar 15, 2021
austingebauer
added a commit
that referenced
this pull request
Mar 15, 2021
austingebauer
added a commit
that referenced
this pull request
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR changes the handling of
jwt_supported_algsto be consistent with the behavior prior to PR #155. This means thatjwt_supported_algswill remain optional and default to the set of algorithms defined in jwt/algs.go#L12-L21 for JWT based authentication.A default of
RS256is still used for OIDC based authentication.Testing
I've tested that JWT auth works without needing to always provide the correct signing algorithm via
jwt_supported_algsfor both JWKS and static key configurations.