Remove provider_config DisplayAttrs.Value #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since that is treated as the default by the UI, and the default should be empty.
calvn
approved these changes
Oct 22, 2020
|
Thanks for addressing this! |
tvoran
added a commit
that referenced
this pull request
Oct 22, 2020
Since that is treated as the default by the UI, and the default should be empty.
tvoran
added a commit
that referenced
this pull request
Oct 22, 2020
This was referenced Oct 22, 2020
tvoran
added a commit
that referenced
this pull request
Oct 29, 2020
Since that is treated as the default by the UI, and the default should be empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove provider_config DisplayAttrs.Value, since that is treated as the default by the UI, and the default should
be empty. This was causing issues with the UI.
Contributor Checklist