Improve authorization error #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a custom allowed_redirect_uris for specific roles we don't show a relationship between the role and the redirect_uri when an authorization error occurred, frustrating the user thinking that the problem is in the role and not in the allowed_redirect_uris flag.
|
|
kalafut
approved these changes
Oct 28, 2020
tvoran
pushed a commit
that referenced
this pull request
Oct 29, 2020
When using a custom allowed_redirect_uris for specific roles we don't show a relationship between the role and the redirect_uri when an authorization error occurred, frustrating the user thinking that the problem is in the role and not in the allowed_redirect_uris flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When using a custom allowed_redirect_uris for specific roles
we don't show a relationship between the role and the
redirect_uri when an authorization error occurred,
frustrating the user thinking that the problem is in
the role and not in the allowed_redirect_uris flag.
This error is common occurred with the CLI when the administrator doesn't add an allowed localhost path.